Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

Fixed issue #20. Added x-www-form-urlencoded ContentType to default o… #21

Merged
merged 1 commit into from
Nov 28, 2015

Conversation

itsjoeconway
Copy link
Contributor

…f HttpController. Allow x-www-form-urlencoded key-values to be sent to HttpController optional arguments like query string params.

…f HttpController. Allow x-www-form-urlencoded key-values to be sent to HttpController optional arguments like query string params.
@itsjoeconway
Copy link
Contributor Author

@anachlas @JesseBlack82 @rosshambrick any of yall can merge this one on review

Future<Response> refreshToken(String _) async {
var authorizationHeader = request.innerRequest.headers[HttpHeaders
.AUTHORIZATION]?.first;
Future<Response> create({String grant_type, String username, String password, String refresh_token}) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

@anachlas
Copy link
Contributor

👍 Like the changes. Also the new formatter is much better, is that from the IntelliJ plugin?

@@ -144,7 +145,41 @@ void main() {
"Authorization" : "Basic ${CryptoUtils.bytesToBase64("com.stablekernel.app1:kilimanjaro".codeUnits)}"},
body: encoder({"grant_type" : "password", "username" : "bob+0@stablekernel.com", "password" : "fobar%"}));
expect(res.statusCode, 401);
});

test("Refresh token responds with token on correct input", () async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

JesseBlack82 added a commit that referenced this pull request Nov 28, 2015
Fixed issue #20. Added x-www-form-urlencoded ContentType to default o…
@JesseBlack82 JesseBlack82 merged commit 44a640c into master Nov 28, 2015
@JesseBlack82 JesseBlack82 deleted the jc/refresh branch November 28, 2015 23:29
@itsjoeconway
Copy link
Contributor Author

@anachlas Use 'dartfmt -l 120 -w lib' The key is the -l 120, which means line length is pinned to 120 instead of that lame ass 80

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants