This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 278
Fixed issue #20. Added x-www-form-urlencoded ContentType to default o… #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f HttpController. Allow x-www-form-urlencoded key-values to be sent to HttpController optional arguments like query string params.
@anachlas @JesseBlack82 @rosshambrick any of yall can merge this one on review |
Future<Response> refreshToken(String _) async { | ||
var authorizationHeader = request.innerRequest.headers[HttpHeaders | ||
.AUTHORIZATION]?.first; | ||
Future<Response> create({String grant_type, String username, String password, String refresh_token}) async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
👍 Like the changes. Also the new formatter is much better, is that from the IntelliJ plugin? |
@@ -144,7 +145,41 @@ void main() { | |||
"Authorization" : "Basic ${CryptoUtils.bytesToBase64("com.stablekernel.app1:kilimanjaro".codeUnits)}"}, | |||
body: encoder({"grant_type" : "password", "username" : "bob+0@stablekernel.com", "password" : "fobar%"})); | |||
expect(res.statusCode, 401); | |||
}); | |||
|
|||
test("Refresh token responds with token on correct input", () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
JesseBlack82
added a commit
that referenced
this pull request
Nov 28, 2015
Fixed issue #20. Added x-www-form-urlencoded ContentType to default o…
@anachlas Use 'dartfmt -l 120 -w lib' The key is the -l 120, which means line length is pinned to 120 instead of that lame ass 80 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f HttpController. Allow x-www-form-urlencoded key-values to be sent to HttpController optional arguments like query string params.