Fix Bad state: NoSuchMethodError: The getter 'length' was called on n… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fodil-a
force-pushed
the
master
branch
2 times, most recently
from
81805bc
to
b89920e
Compare
|
also fixes #8 by replacing deprecated calls from analyzer |
sdxv
reviewed
Dec 8, 2020
| final fileUnit = parseFile( | ||
| path: uri.toFilePath(windows: Platform.isWindows), | ||
| featureSet: FeatureSet.fromEnableFlags2( | ||
| flags: [], sdkLanguageVersion: Version(2, 8, 0))); |
There was a problem hiding this comment.
What is the significance of using version 2.8.0?
sdxv
reviewed
Dec 8, 2020
| @@ -8,7 +8,7 @@ environment: | |||
| sdk: ">=2.0.0 <3.0.0" | |||
|
|
|||
| dependencies: | |||
| analyzer: '>=0.32.0 <0.50.0' | |||
| analyzer: '>=0.40.6 <0.41.0' | |||
There was a problem hiding this comment.
This can be more permissive
Suggested change
| analyzer: '>=0.40.6 <0.41.0' | |
| analyzer: '>=0.40.1 <0.42.0' |
sdxv
suggested changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ull.
The issue makes aqueduct db generate crash 100% of the time if you use a version of dart > 2.8.
You need to merge and release a version of isolate-executor and aqueduct ASAP to fix the issue dating from june.