Updates to allow multiple label types in one item #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes out of the label extension discussion which occurred on April 22, 2022. The initial suggestion coming out of that discussion was that we would make the properties for the label extension apply at the asset level instead of the item level. After thinking this through I'm not sure that's the best solution. The solution proposed here would instead change the
label:typeproperty tolabel:typesand would accept an array of enums allowing both raster and vector labels to be present as assets within this one item. This would make the upgrade from older versions to this version a trivial process.This PR also adds a mention of the classification extension which should be used to provide the mapping of raster pixel values to human-readable class names.