Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge azavea/stac-ml-aoi-extension #1

Merged
merged 15 commits into from
May 12, 2021
Merged

Merge azavea/stac-ml-aoi-extension #1

merged 15 commits into from
May 12, 2021

Conversation

duckontheweb
Copy link
Collaborator

@duckontheweb duckontheweb commented Apr 29, 2021

Opening this to bring the content from azavea/stac-ml-aoi-extension into the stac-extensions org. I have tried to leave the original content intact and make the minimum number of changes required to fit the content into the stac-extensions/template format and get the build to pass. The intention is to open issues on this repo for any additional work needed on the extension (e.g. adding examples, additional reformatting, etc.).

A couple of notes:

  • @echeipesh is the owner since he made all commits to the original repo. Let me know if this should change. I'm also happy to be a co-owner or sole owner if either of those options make sense).
  • Did a little work to fit the content into the template format, but more probably needs to be done. I thought it would be best to do this through issues + atomic commitsPRs rather than as part of this merge.
  • Had to remove the front matter in the ADR docs to make remark happy, let me know if there's a reason that needs to be in there.

@duckontheweb duckontheweb requested a review from jisantuc April 29, 2021 23:36
@duckontheweb duckontheweb requested a review from kbgg May 11, 2021 16:14
Copy link
Collaborator

@echeipesh echeipesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thank you for pulling this into the light, everything looks good and I agree with deferring needed fix-up into followup. I fully endorse growing the owner list to people who are thinking and contributing to this spec such as yourself.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@duckontheweb
Copy link
Collaborator Author

@kbgg Thanks for catching those typos, I've fixed them in 37d7387. I think there's a good chance we'll want to re-structure that main README anyway to be more consistent with some of the other STAC Extensions, but it's good to catch these in the review anyway.

@duckontheweb duckontheweb merged commit 02d6d7a into main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants