Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pystac/pydantic definitions for ML-AOI extension #8

Merged
merged 21 commits into from
Mar 28, 2024

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Mar 6, 2024

TODO

  • update changelog
  • update tests & examples
    • test examples against JSON schema
    • add more combinations of pystac extensions using ML-AOI utilities
  • release v0.2.0 with make bump VERSION=0.2.0 call once merged
    (fixes ml-aoi extension schema page does not exists #9)

@fmigneault fmigneault force-pushed the pystac-pydantic-ext-impl branch from 2151edb to 34675b9 Compare March 12, 2024 18:54
@fmigneault fmigneault changed the title [wip] add pystac/pydantic definitions for ML-AOI extension add pystac/pydantic definitions for ML-AOI extension Mar 27, 2024
@fmigneault fmigneault marked this pull request as ready for review March 27, 2024 20:08
@fmigneault
Copy link
Collaborator Author

@m-mohr
The STAC Node Validator fails the deploy step because the URI of ML-AOI schema cannot be found, but I want to validate everything works with mocked schema locations before releasing them. We have a chicken-egg situation here.
I would like to know your preferred approach regarding the CI for STAC extensions and resolving those missing refs issues.

@fmigneault fmigneault self-assigned this Mar 27, 2024
@m-mohr
Copy link
Contributor

m-mohr commented Mar 27, 2024

That's not the case. The validator can handle this case. You need to specify the correct version numbers in package.json (search for 1.0.0 occurances and replace with 0.1.0). Generally, I'd recommend to search (and replace) the whole repo for "template" and "1.0.0" and replace it with the corresponding values that apply for this repo. Afterwards delete release and tag and release again with the updated files.

@fmigneault
Copy link
Collaborator Author

@m-mohr
I see. And once I bump the versions with the new minor release, I simply need to update the package.json with the relevant numbers as well?

@m-mohr
Copy link
Contributor

m-mohr commented Mar 27, 2024

yes

@fmigneault fmigneault merged commit 8c35d8a into main Mar 28, 2024
14 checks passed
@fmigneault fmigneault deleted the pystac-pydantic-ext-impl branch March 28, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ml-aoi extension schema page does not exists
2 participants