Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #122 - bug with type casting when using "in" operator #124

Merged
merged 6 commits into from
Jun 14, 2022
Merged

Conversation

bitner
Copy link
Collaborator

@bitner bitner commented Jun 13, 2022

Fix for a bug with type casting when using the "in" operator. (Fixes #122)

@bitner bitner requested a review from mmcfarland June 13, 2022 14:21
Copy link
Collaborator

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a staging environment and IN queries are now working correctly 👍

@@ -234,7 +238,6 @@ INSERT INTO cql2_ops (op, template, types) VALUES
('-', '%s - %s', NULL),
('*', '%s * %s', NULL),
('/', '%s / %s', NULL),
('in', '%s = ANY (%s)', NULL),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of migrations, it doesn't look like the table is recreated so deleted rows will remain. In this case, is that problematic?

sql/002b_cql.sql Outdated Show resolved Hide resolved
@bitner bitner merged commit 7b5ff07 into main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect cql2_query generation when using the in operator
2 participants