Check the min requirements in CI #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 11 11
Lines 833 833
=======================================
Hits 726 726
Misses 107 107 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gadomski
force-pushed
the
check-min-requirements
branch
from
53d958b to
3de586b
Compare
+1 on this |
pjhartzell
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Our
requirements-min.txtgot out-of-sync with our actual requirements. This adds a check to CI to make sure they stay in sync.An alternative would be to remove
requirements-min.txt. However, that makes it hard to know when our package breaks at the lower bounds of our dependencies. There's a complexity vs. protection tradeoff here.I don't think these changes need to be in the CHANGELOG, as they're only infrastructure tweaks.
I also sorted the
requirements-dev.txtfile -- I find it easier to check what we depend on visually if that list is sorted 🤷🏽.Update: I really thought there should be A Better Way™ of doing this, and I finally stumbled across pypa/pip#8085 which describes exactly the solution that I'd want. And it doesn't exist yet. So here we are.
PR Checklist: