fix: warning from get_all_items deprecation (#1203)

Also, remove usages of deprecated functions.
stac-utils · Aug 10, 2023 · 27ea872 · 27ea872
1 parent bd5c80b
commit 27ea872
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/docs/tutorials/pystac-introduction.ipynb b/docs/tutorials/pystac-introduction.ipynb
@@ -1671,7 +1671,7 @@
    ],
    "source": [
     "# get all items anywhere below this catalog on the STAC tree\n",
-    "list(cat.get_all_items())"
+    "list(cat.get_items(recursive=True))"
    ]
   },
   {
@@ -1812,7 +1812,7 @@
    ],
    "source": [
     "print(\"\\n**Items**\")\n",
-    "for i in cat.get_all_items():\n",
+    "for i in cat.get_items(recursive=True):\n",
     "    print(i.id)"
    ]
   },
@@ -6096,7 +6096,7 @@
     }
    ],
    "source": [
-    "item = next(mycat.get_all_items())\n",
+    "item = next(mycat.get_items(recursive=True))\n",
     "item.get_single_link(\"parent\").get_href()"
    ]
   },
@@ -6135,7 +6135,7 @@
     }
    ],
    "source": [
-    "item = next(mycat.get_all_items())\n",
+    "item = next(mycat.get_items(recursive=True))\n",
     "item.get_single_link(\"parent\").get_href()"
    ]
   }

diff --git a/docs/tutorials/pystac-spacenet-tutorial.ipynb b/docs/tutorials/pystac-spacenet-tutorial.ipynb
@@ -250,7 +250,7 @@
    "source": [
     "bounds = [\n",
     "    list(\n",
-    "        GeometryCollection([shape(s.geometry) for s in spacenet.get_all_items()]).bounds\n",
+    "        GeometryCollection([shape(s.geometry) for s in spacenet.get_items(recursive=True)]).bounds\n",
     "    )\n",
     "]\n",
     "vegas.extent.spatial = pystac.SpatialExtent(bounds)"

diff --git a/pystac/catalog.py b/pystac/catalog.py
@@ -585,12 +585,12 @@ def get_all_items(self) -> Iterator[Item]:
                 child links.
         """
         warnings.warn(
-            "get_item is deprecated and will be removed in v2",
+            "get_all_items is deprecated and will be removed in v2",
             DeprecationWarning,
         )
         return chain(
             self.get_items(),
-            *(child.get_all_items() for child in self.get_children()),
+            *(child.get_items(recursive=True) for child in self.get_children()),
         )
 
     def get_item_links(self) -> List[Link]: