Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use RefResolver #1186

Closed
gadomski opened this issue Jul 7, 2023 · 6 comments · Fixed by #1215
Closed

Don't use RefResolver #1186

gadomski opened this issue Jul 7, 2023 · 6 comments · Fixed by #1215
Assignees

Comments

@gadomski
Copy link
Member

gadomski commented Jul 7, 2023

As of jsonschema v4.18, RefResolver is deprecated:

DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.

This issue is to track the need to update to The New Way.

@vincentsarago
Copy link
Member

FYI I'm getting some errors in titiler CI with the latest jsonschema developmentseed/titiler#664 (comment)

@gadomski
Copy link
Member Author

Thanks for the report Vincent! I wonder if we should ceil jsonschema below v4.18 for the time being? What's your sense of how broken things are over there?

@vincentsarago
Copy link
Member

vincentsarago commented Jul 12, 2023

Yep that's what I did in #1189 😅

What's your sense of how broken things are over there?

I have no idea, it's weird that they broke something in a patch release. I'm pretty sure this was unintentional but knowing it's deprecated I feel it's safer to set an upper bound to the requirement so one they do remove it pystac should continue working

@gadomski
Copy link
Member Author

#1189 is released in v1.8.2.

@jsignell
Copy link
Member

jsignell commented Sep 7, 2023

I'm going to look into this a bit today to see if the timing is right to pick it up

@jsignell jsignell self-assigned this Sep 7, 2023
@2320sharon
Copy link

Hi @jsignell, thank you for addressing this issue. It's blocking the resolution of #1214, which is affecting Jupyter Lab in downstream applications. We truly appreciate your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants