Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set upper bound for jsonschema version #1189

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented Jul 12, 2023

Related Issue(s):

#1186

Description:

with 4.18.1 and 4.18.2, jsonschema will raise an error. While we wait for the removal of RefResolver it would be safer to pin jsonschema with an upper bound to <4.18

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (30e34f1) 92.01% compared to head (621b43c) 92.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1189   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          51       51           
  Lines        6809     6809           
  Branches     1007     1007           
=======================================
  Hits         6265     6265           
  Misses        368      368           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski added this to the 1.8.2 milestone Jul 12, 2023
@gadomski gadomski enabled auto-merge July 12, 2023 17:59
@gadomski gadomski added this pull request to the merge queue Jul 12, 2023
Merged via the queue into stac-utils:main with commit bac884e Jul 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants