Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple proj versions #1081

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 6, 2023

Related Issue(s):

Description:

This is a pull request against the v1.7 branch, and is intended to be immediately released in a v1.7.2 bugfix release. Once released, it should be merged into main via a second PR.

When we updated the projection extension version, we inadvertently broke any downstreams that used the ProjectionExtension class on items w/ v1.0.0 of the extension. That was bad. This fixes that problem, and provides a pattern that we can use when we do future extension upgrades.

There were no functional changes to the projection extension in #989 so I think we can safely assume we can use the same class interface for v1.0.0 and v1.1.0 items.

This really is a kludgy bandaid, but might be all that we can do until v2.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski self-assigned this Apr 6, 2023
@gadomski gadomski added this to the 1.7.2 milestone Apr 6, 2023
pystac/extensions/base.py Show resolved Hide resolved
@gadomski gadomski merged commit 81587b1 into v1.7 Apr 6, 2023
@gadomski gadomski deleted the allow-multiple-extension-schema branch April 6, 2023 14:48
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.31%. Comparing base (f7398bc) to head (8c46f02).

Files Patch % Lines
pystac/extensions/projection.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v1.7    #1081      +/-   ##
==========================================
- Coverage   90.34%   90.31%   -0.03%     
==========================================
  Files          47       47              
  Lines        6213     6219       +6     
  Branches      929      931       +2     
==========================================
+ Hits         5613     5617       +4     
- Misses        422      423       +1     
- Partials      178      179       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants