Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use three digits for ~= v0.* deps #1211

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Aug 28, 2023

Description:

I realized recently that using ~= and two digits for dependencies that start with 0. is more-or-less meaningless, since it expands to >=0.x,<1.0. This updates to add a third digit for 0.* dependencies.

This also fixes our bench check caused by asv breaking change in their CLI that popped up due to the dependency pinning problem. Doesn't need a changelog.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell August 28, 2023 18:33
@gadomski gadomski self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2db7613) 92.01% compared to head (11f6ecf) 92.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          51       51           
  Lines        6813     6813           
  Branches     1009     1009           
=======================================
  Hits         6269     6269           
  Misses        368      368           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski force-pushed the three-digits-zero-leading-deps branch from eee6ab9 to 11f6ecf Compare August 28, 2023 19:51
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@gadomski gadomski added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 922707d Aug 29, 2023
@gadomski gadomski deleted the three-digits-zero-leading-deps branch August 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants