Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow future extensions to be used #1231

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Sep 26, 2023

Related Issue(s):

Description:

When loading extension data, extension implementations should use startswith (or whatever) to detect the presence of the extension, not an exact string match.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pystac/extensions/classification.py 96.03% <100.00%> (-0.37%) ⬇️
pystac/extensions/mgrs.py 98.70% <100.00%> (+0.01%) ⬆️
pystac/extensions/base.py 92.30% <80.00%> (-2.22%) ⬇️
pystac/extensions/eo.py 93.17% <50.00%> (-0.76%) ⬇️
pystac/extensions/grid.py 96.22% <50.00%> (-3.78%) ⬇️
pystac/extensions/label.py 93.31% <50.00%> (-0.53%) ⬇️
pystac/extensions/projection.py 97.08% <50.00%> (-1.44%) ⬇️
pystac/extensions/raster.py 90.22% <66.66%> (-0.57%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit that you should feel free to ignore but LGTM other than needs CHANGELOG.

pystac/extensions/base.py Outdated Show resolved Hide resolved
@gadomski gadomski added this pull request to the merge queue Sep 27, 2023
Merged via the queue into stac-utils:main with commit 9d6b146 Sep 27, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework extensions to handle "future" versions correctly
2 participants