Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keywords to common metadata #1443

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Add keywords to common metadata #1443

merged 4 commits into from
Oct 15, 2024

Conversation

tylanderson
Copy link
Contributor

Related Issue(s):

Description:

Moves keywords into common metadata for STAC spec 1.1.0

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (778725d) to head (e700e93).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1443   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          52       52           
  Lines        7245     7251    +6     
  Branches     1019     1019           
=======================================
+ Hits         6609     6615    +6     
  Misses        457      457           
  Partials      179      179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski self-requested a review October 15, 2024 13:21
gadomski
gadomski requested changes Oct 15, 2024
View reviewed changes
pystac/common_metadata.py Outdated Show resolved Hide resolved
@gadomski gadomski linked an issue Oct 15, 2024 that may be closed by this pull request
Move keywords up out of collections into common metadata #1376
Closed
@gadomski gadomski enabled auto-merge October 15, 2024 20:34
@gadomski gadomski added this pull request to the merge queue Oct 15, 2024
Merged via the queue into stac-utils:main with commit 9f5249f Oct 15, 2024
20 checks passed
bmcandr pushed a commit to bmcandr/pystac that referenced this pull request Oct 25, 2024
@tylanderson @gadomski @bmcandr
Add keywords to common metadata (stac-utils#1443)
dce0e00 
* add keywords to common metadata

* Update pystac/common_metadata.py

* fix: lint

---------

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move keywords up out of collections into common metadata
2 participants
@tylanderson @gadomski