Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1483 #1484

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

remicres
Copy link
Contributor

@remicres remicres commented Dec 15, 2024

Related Issue(s):

Description:

Quick fix for #1483 1483

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (97f87cb) to head (d8e5645).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files          52       52           
  Lines        7251     7253    +2     
  Branches      875      877    +2     
=======================================
+ Hits         6611     6613    +2     
  Misses        460      460           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! If you are able to add a test that would be great.

@remicres
Copy link
Contributor Author

Ok I'll try to add a test

@gadomski gadomski enabled auto-merge December 17, 2024 23:28
@gadomski gadomski added this pull request to the merge queue Dec 17, 2024
Merged via the queue into stac-utils:main with commit e611092 Dec 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants