Skip to content

Commit

Permalink
fix(tests): use a fixture for requests version
Browse files Browse the repository at this point in the history
  • Loading branch information
gadomski committed Oct 7, 2024
1 parent 619cba8 commit 2cef1f6
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
8 changes: 8 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import importlib.metadata

import pytest


@pytest.fixture
def requests_version() -> str:
return importlib.metadata.version("requests")
4 changes: 2 additions & 2 deletions tests/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ def test_main_fails(runner: CliRunner) -> None:


def test_retrieve_called_with_auth_headers(
request: pytest.FixtureRequest, runner: CliRunner
request: pytest.FixtureRequest, runner: CliRunner, requests_version: str
) -> None:
if request.config.getoption("typeguard_packages"):
pytest.skip(
"The import hook that typeguard uses seems to break the mock below."
)

expected_headers = {
"User-Agent": "python-requests/2.32.3",
"User-Agent": f"python-requests/{requests_version}",
"Accept-Encoding": "gzip, deflate",
"Accept": "*/*",
"Connection": "keep-alive",
Expand Down
4 changes: 2 additions & 2 deletions tests/test_validations.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ def sample_item() -> Generator[pystac.Item, None, None]:


@pytest.fixture
def expected_headers() -> Generator[Dict[str, str], None, None]:
def expected_headers(requests_version: str) -> Generator[Dict[str, str], None, None]:
yield {
"User-Agent": "python-requests/2.32.3",
"User-Agent": f"python-requests/{requests_version}",
"Accept-Encoding": "gzip, deflate",
"Accept": "*/*",
"Connection": "keep-alive",
Expand Down

0 comments on commit 2cef1f6

Please sign in to comment.