fix comma-separated bbox value parsing (#160)

stac-utils · Feb 18, 2022 · d114c48 · d114c48
1 parent f9d11c9
commit d114c48
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/libs/api.js b/libs/api.js
@@ -51,8 +51,8 @@ const extractBbox = function (params) {
     if (typeof bbox === 'string') {
       try {
         bboxArray = JSON.parse(bbox)
-      } catch(e) {
-        bboxArray = bbox.split(',')
+      } catch (e) {
+        bboxArray = bbox.split(',').map(parseFloat)
       }
     } else {
       bboxArray = bbox
@@ -629,5 +629,6 @@ module.exports = {
   searchItems,
   API,
   parsePath,
-  extractIntersects
+  extractIntersects,
+  extractBbox
 }
diff --git a/tests/test_api_bbox.js b/tests/test_api_bbox.js
@@ -0,0 +1,30 @@
+const test = require('ava')
+const api = require('../libs/api')
+
+test('extractBboxNull', (t) => {
+  const params = {}
+  const intersectsGeometry = api.extractBbox(params)
+  t.falsy(intersectsGeometry,
+    'Returns undefined when no bbox parameter')
+})
+
+test('extractBbox JSON array', (t) => {
+  const params = { bbox: [0, 0, 1, 1] }
+  const intersectsGeometry = api.extractBbox(params)
+  t.is(intersectsGeometry.coordinates[0].length, 5)
+  t.is(intersectsGeometry.coordinates[0][0][0], 0)
+})
+
+test('extractBbox comma-separated value', (t) => {
+  const params = { bbox: '0,0,1,1' }
+  const intersectsGeometry = api.extractBbox(params)
+  t.is(intersectsGeometry.coordinates[0].length, 5)
+  t.is(intersectsGeometry.coordinates[0][0][0], 0)
+})
+
+test('extractBbox comma-separated value with whitespace', (t) => {
+  const params = { bbox: '0  ,  0.3  , 1.0,\t1' }
+  const intersectsGeometry = api.extractBbox(params)
+  t.is(intersectsGeometry.coordinates[0].length, 5)
+  t.is(intersectsGeometry.coordinates[0][0][0], 0)
+})