Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split system tests into separate files #191

Merged
merged 15 commits into from
Feb 23, 2022
Merged

Split system tests into separate files #191

merged 15 commits into from
Feb 23, 2022

Conversation

marchuffnagle
Copy link
Contributor

Closes #186

This also:

  • Adds types to the tests (As much as I like ava, it makes typing the context really nasty)
  • Makes the tests self-contained. Teach test file is responsible for creating the ES indexes and data that it depends on
  • Adds common VSCode config

philvarner
philvarner approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@philvarner philvarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This great. I just started trying to modify a few tests, and it's a mess that they're all in the same file

@marchuffnagle marchuffnagle merged commit c79ea5e into main Feb 23, 2022
@marchuffnagle marchuffnagle deleted the split-api-tests branch February 23, 2022 21:41
philvarner pushed a commit that referenced this pull request Feb 28, 2022
Split system tests into separate files (#191)
b0b49ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philvarner philvarner philvarner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split API tests apart into separate files
2 participants
@marchuffnagle @philvarner