Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-hook and post-hook examples, upgrade serverless to 3.x, upgra… #294

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Oct 10, 2022

Related Issue(s):

Proposed Changes:

The main change is to add:

  • Added pre-hook and post-hook Lambda examples

Several other things come along with this. These were tested extensively in a forked repo.

  • The serverless.yml.example file now has zone awareness enabled and an even number of
    Elasticsearch nodes
  • Upgrade serverless to 3.x
  • Remove use of serverless-psuedo-parameters
  • Upgrade to Node 16

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@@ -103,7 +134,7 @@ resources:
Properties:
Endpoint: !GetAtt ingestQueue.Arn
Protocol: sqs
Region: "#{AWS::Region}"
Region: "${aws:region}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now a features of serverless 3, whereas before it was in the pseudo-parameters plugin.

@philvarner philvarner marked this pull request as ready for review October 10, 2022 21:32
@philvarner philvarner merged commit e264d91 into main Oct 11, 2022
@philvarner philvarner deleted the pv/pre-and-post-hook-examples branch October 11, 2022 13:25
@philvarner philvarner added this to the 0.5.0 milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants