Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in a variable name #318

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

kurtmckee
Copy link
Contributor

Related Issue(s):

  • N/A

Proposed Changes:

  1. Fix typo in variable name: exisiting -> existing

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

`exisiting` -> `existing`
@philvarner philvarner merged commit f952c22 into stac-utils:main Dec 12, 2022
@kurtmckee kurtmckee deleted the patch-1 branch December 12, 2022 15:53
@kurtmckee kurtmckee restored the patch-1 branch December 12, 2022 15:54
@kurtmckee kurtmckee deleted the patch-1 branch December 12, 2022 15:55
@kurtmckee
Copy link
Contributor Author

@philvarner Something happened with my original commit, 0c7ed5f, which broke my commit signature and now marks the modified commit as "Unverified". The timeline in this PR suggests that this was a manual change that happened a few minutes before the PR was merged.

My account has vigilant mode enabled and these types of changes will result in a more uncertain commit history in the GitHub interface. Could you let me know what happened here?

@kurtmckee kurtmckee restored the patch-1 branch December 12, 2022 16:00
@philvarner
Copy link
Collaborator

I think I did an "Update with rebase" from the GH UI.

@kurtmckee
Copy link
Contributor Author

Ah, makes sense. If you encounter merge conflicts on PR's in the future, please give me an opportunity to fix that so the commit signatures remain intact. Thanks! 😀

@philvarner
Copy link
Collaborator

Will do. I'm going to look into vigilant mode, also.

@kurtmckee
Copy link
Contributor Author

Nice! I started signing commits and tags six months ago and have tried to watch how that shows up in the GH interface. I only enabled vigilant mode last week and have found a few interesting corner cases.

What happened in this PR is new to me, but late last week I discovered that when I leave code suggestions in PR reviews -- and when the PR author commits those suggestions directly from the PR comment -- it shows up as "Partially verified" because I never actually committed anything! Instead, it's attributed to me by way of "Co-authored by" (example).

Just wanted to share my experience so far. 👍

@kurtmckee kurtmckee deleted the patch-1 branch June 12, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants