Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing #25

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix typing #25

merged 3 commits into from
Jul 12, 2023

Conversation

gadomski
Copy link
Member

Includes:

  • autoupdate to pre-commit hooks
  • switch mypy to strict mode
  • typing fixes
  • py.typed file, for downstreams
  • some formatting fixes

@gadomski gadomski added this to the v0.1.1 milestone Jul 11, 2023
@gadomski gadomski self-assigned this Jul 11, 2023
@gadomski gadomski linked an issue Jul 11, 2023 that may be closed by this pull request
Task.upload_item_assets_to_s3 has wrong typing for item argument. #24
Closed
@gadomski gadomski enabled auto-merge (rebase) July 11, 2023 21:02
paulpilone
paulpilone approved these changes Jul 12, 2023
View reviewed changes
Copy link

@paulpilone paulpilone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gadomski gadomski merged commit be0bc64 into main Jul 12, 2023
@gadomski gadomski deleted the issues/24-typing branch July 12, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulpilone paulpilone paulpilone approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging this pull request may close these issues.

Task.upload_item_assets_to_s3 has wrong typing for item argument.
2 participants
@gadomski @paulpilone