Merge pull request #203 from tschaub/exception-order

Reorder exception handlers to avoid unreachable code
stac-utils · Mar 15, 2022 · c1b4a72 · c1b4a72
2 parents 3abf536 + f5b0b48
commit c1b4a72
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,13 @@ All notable changes to this project will be documented in this file.
 
 The format is (loosely) based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
-## [3.0.0] - 2022-03-11
+## Unreleased - 2022-03-14
+
+### Fixed
+
+- Reordered exception handlers to avoid unreachable code
+
+## [v3.0.0] - 2022-03-11
 
 ### Added
 

diff --git a/stac_validator/validate.py b/stac_validator/validate.py
@@ -285,12 +285,12 @@ def run(cls):
                 cls.valid = True
                 message = cls.default_validator(stac_type)
 
-        except ValueError as e:
-            message.update(cls.create_err_msg("ValueError", str(e)))
         except URLError as e:
             message.update(cls.create_err_msg("URLError", str(e)))
         except JSONDecodeError as e:
             message.update(cls.create_err_msg("JSONDecodeError", str(e)))
+        except ValueError as e:
+            message.update(cls.create_err_msg("ValueError", str(e)))
         except TypeError as e:
             message.update(cls.create_err_msg("TypeError", str(e)))
         except FileNotFoundError as e: