Fix top-level is_valid flag for recursive jsonschema exceptions
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recursive validator catches jsonschema exceptions and sets the appropriate message. However, because it catches and doesn't re-raise the exception, the higher-level `run` method was still setting `is_valid` to `True`. This PR fixes the problem by returning `False` from the recursive validator if a jsonschema exception was caught, and True otherwise. Includes a unit test demonstrating the issue.
gadomski
changed the title
gadomski
changed the title
is_valid flag for recursive jsonschema exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursive validator catches jsonschema exceptions and sets the appropriate message. However, because it catches and doesn't re-raise the exception, the higher-level
runmethod was still settingis_validtoTrue. This PR fixes the problem by returningFalsefrom the recursive validator if a jsonschema exception was caught, and True otherwise. Includes a unit test demonstrating the issue.Related issues
stac-validatorfor our validation function stactools#255