Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Refs to dynamic (1, N) blocks #284

Merged
merged 5 commits into from
May 9, 2022
Merged

Fix for Refs to dynamic (1, N) blocks #284

merged 5 commits into from
May 9, 2022

Conversation

ManifoldFR
Copy link
Member

This PR:

  • adds tests where user takes (1,n) or (n,1) blocks of matrices as Eigen::Ref and returns them to NumPy
  • fixes the corner case where (n,1) was taken
  • builds on fix for RowMajor in 471b8d6

ManifoldFR and others added 3 commits May 9, 2022 10:22
jcarpent
jcarpent requested changes May 9, 2022
View reviewed changes
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick minor change ;)

include/eigenpy/numpy-allocator.hpp Outdated Show resolved Hide resolved
@ManifoldFR @jcarpent
numpy-allocator: remove useless variable def
1fe931f 
Co-authored-by: Justin Carpentier <justin.carpentier@inria.fr>
@ManifoldFR
Copy link
Member Author

ManifoldFR commented May 9, 2022 •
edited
Loading

Writing a commit for the const case now

edit: done

@jcarpent jcarpent merged commit 6486d6d into stack-of-tasks:devel May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManifoldFR @jcarpent