Copy std-vector and std-map from Pinocchio #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
ManifoldFR
changed the title
jcarpent
requested changes
Oct 4, 2022
There was a problem hiding this comment.
@ManifoldFR Thanks a lot for this PR.
Could you remove aligned_vector, which is not useful to have I do think?
Ok, will do so |
|
Rebased on devel. |
This was referenced Nov 28, 2022
|
Now it should be fixed. I will manually squash my commits and force push. |
ManifoldFR
changed the title
all: change __se3_* for __pinocchio_* for pragma once all: change namespace from se3 to pinocchio The previous se3 namespace is now deprecated but can still be used all: remove license from files [binding][std::map] Create Python visitors for std::map for aligned allocator. (and also for non-aligned maps, for the sake of completion) [referenceConfigurations] review comments of @jcarpent on #666 [bindings][pickling] add support for vector<T> aligned_vector<T> map<T> pickling. update model and data classes to make their members picklable python: add converter from Python list to std::vector or aligned_vector python: fix issue on GCC related to namespace bp all: fix template issue python/utils: factorization of the code python/vector: add conversion tolist for std::vector python/utils: return by reference when creating list python/contact: fix doc python/utils: handle std::vector for non const reference python: add helpers to return Eigen object from std containers python/utils: add return of the class for StdVector helpers python: fix return type core: fix merging issues all: fix merging python: make the code compliant for casadi bindings python/utils: fix entry type for StdVectorPythonVisitor python/utils: enhance API exposed for std::vector python: add copy constructor and method to std::vector python: expose operator{==,!=} for std::vector Revert "python: expose operator{==,!=} for std::vector" This reverts commit 6710dd4758791b3eee1ac444945e7f507aece7f6. python/utils: update std-vector exposition python: fix issues with const reference as input argument
Commits from downstream are rebased & squashed
(std-map) Fix include guard * apply pre-commit formatting * rename namespace
for more information, see https://pre-commit.ci
[Python] Introduce struct to expose both std::vector and aligned_vector
all: change __se3_* for __pinocchio_* for pragma once
all: change namespace from se3 to pinocchio
The previous se3 namespace is now deprecated but can still be used
all: remove license from files
[bindings][pickling] add support for vector<T> aligned_vector<T> map<T> pickling.
update model and data classes to make their members picklable
[bindings][pickling] 1) fix includes. make picklemap borrow from picklevector
2) use pickle support for rest of data and some more of model vectors
python: add converter from Python list to std::vector or aligned_vector
python: fix issue on GCC related to namespace bp
python: fix namespace issue
python/vector: add conversion tolist for std::vector
python/utils: return by reference when creating list
python/utils: add return of the class for StdVector helpers
python: fix return type
python/pickle: fix pickling of std::map
python: fix potential bug with C++11
python: make the code compliant for casadi bindings
python: fix arg name
python/pickle: fix compatibility issue
Compilation issues with recent version of Boost
python: add copy constructor and method to std::vector
python: expose operator{==,!=} for std::vector
Revert "python: expose operator{==,!=} for std::vector"
This reverts commit 6710dd4758791b3eee1ac444945e7f507aece7f6.
python/utils: update std-vector exposition
python: fix issues with const reference as input argument
python: fix pickling of Pinocchio data structure
remove references to aligned
* add test_std_vector.py * fix copyable.hpp's include guards & namespace * same for pickle-vector * expose std::vector for VectorXd, MatrixXd, VectorXi, MatrixXi
for more information, see https://pre-commit.ci
* tests we can expose std::vector<Matrix3d> * test input and returning std::vector<Matrix> objects * test specific functions for specific dims
for more information, see https://pre-commit.ci
* does not work properly
for more information, see https://pre-commit.ci
…trices * bp::extract will construct an Eigen::Ref on the fly as an rvalue using the registered converter * move overload_base_get_item_for_std_vector from pinocchio to here -- changes behaviour of __getitem__ * redef exposeStdVectorEigenSpecificType to overload the boost vector_indexing_suite __getitem__ * move exposeStdVectorEigenSpecificType to std-vector.hpp header
for more information, see https://pre-commit.ci
std-map/std-vector: add mention to file heading
for more information, see https://pre-commit.ci
…utput layout eigen-allocator: try a fix for mutable Eigen::Ref from Python array with "wrong" layout * trick transposes pyArray to get the right layout :)
* should take Eigen::Ref of const (to dispatch to proper EigenAllocator)
unittest/eigen_ref.cpp: asConstRef should take input as Ref<const T>
* fix includes * comment out edge cases
& update its docstring
remove useless include remove comment between includes (not sorted by pre-commit anymore) core/std-vector.hpp * fix using-ctor for older cpp versions * fix warning about conversion
jcarpent
approved these changes
Dec 5, 2022
|
Nice work @ManifoldFR and @fabinsch. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recovered the history using
git-filter-repo, squashed and rebased it into a single big commit before merging the files' history into eigenpy.TODO
utils/copyable.hppheader from PinocchioCloses #324