Tests: add user-struct test #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ create struct with fixed-size members, expose with setter
jcarpent
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test wherein a user-defined struct containing fixed-size Eigen members are exposed with getters and setters (similarly to
pinocchio.GeometryObject'smeshColormember).With the
-mavx2compile flag, the test succeeds with Boost>=1.77, but fails triggering a segfault on 1.76 and 1.74 (which is required by conda ROS noetic) when assigning to theEigen::Vector4dtype member a follows:However, a slicing-assignment
ms.y[:] = ydoes not trigger a segfault.Assigning to the Vector3d member does not trigger a segfault.
Without the AVX flag, the test does not fail (so the CI will pass).
Compiler: clang++ 15
Environment: conda environment