-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run-integration-test): Integrate interu tool into action #29
Conversation
124abb0
to
247bde5
Compare
d4745de
to
c72a702
Compare
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
I think this PR is ready to be merged. The test failures need more investigation which is only possible once log and K8s event collection is in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of suggestions
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
84b5d85
to
65f5fc6
Compare
65f5fc6
to
7db8e66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the curl/chmod would need sudo
. I have made suggestions which instead curls to a non-root-owned directory and then uses sudo install
.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
5d5dd29
to
b3a7d76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c7b4c6a
to
7bbd08f
Compare
7bbd08f
to
b51ec05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Blocked by #30, part of stackabletech/issues#659