Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(run-integration-test): Integrate interu tool into action #29

Merged
merged 16 commits into from
Jan 20, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jan 10, 2025

Blocked by #30, part of stackabletech/issues#659

@Techassi Techassi force-pushed the feat/run-integration-test-use-interu branch from d4745de to c72a702 Compare January 13, 2025 12:49
Techassi and others added 2 commits January 14, 2025 11:42
@Techassi Techassi marked this pull request as ready for review January 17, 2025 08:27
@Techassi
Copy link
Member Author

I think this PR is ready to be merged.

The test failures need more investigation which is only possible once log and K8s event collection is in place.

@Techassi Techassi requested a review from NickLarsenNZ January 17, 2025 08:28
@Techassi Techassi requested a review from NickLarsenNZ January 17, 2025 08:56
NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 17, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of suggestions

Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@Techassi Techassi force-pushed the feat/run-integration-test-use-interu branch 2 times, most recently from 84b5d85 to 65f5fc6 Compare January 17, 2025 10:15
@Techassi Techassi force-pushed the feat/run-integration-test-use-interu branch from 65f5fc6 to 7db8e66 Compare January 17, 2025 10:16
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the curl/chmod would need sudo. I have made suggestions which instead curls to a non-root-owned directory and then uses sudo install.

Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@Techassi Techassi force-pushed the feat/run-integration-test-use-interu branch from 5d5dd29 to b3a7d76 Compare January 17, 2025 13:44
NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 17, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi force-pushed the feat/run-integration-test-use-interu branch 2 times, most recently from c7b4c6a to 7bbd08f Compare January 20, 2025 14:26
@Techassi Techassi force-pushed the feat/run-integration-test-use-interu branch from 7bbd08f to b51ec05 Compare January 20, 2025 14:36
@Techassi Techassi requested a review from NickLarsenNZ January 20, 2025 14:40
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi merged commit 2d703e5 into main Jan 20, 2025
2 checks passed
@Techassi Techassi deleted the feat/run-integration-test-use-interu branch January 20, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants