Skip to content

feat(send-slack-notification): Send failure and success message #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 9, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented May 8, 2025

This PR extends the capabilities of the send-slack-notification action:

  • It is now possible to send failure and success messages
  • The Slack thread ID retrieval is now idempotent

@Techassi Techassi self-assigned this May 8, 2025
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering May 8, 2025
@Techassi Techassi force-pushed the feat/failure-success-notifications branch from b596fbd to 6d36995 Compare May 9, 2025 10:42
@Techassi Techassi marked this pull request as ready for review May 9, 2025 10:42
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering May 9, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review May 9, 2025 10:42
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 9, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few suggestions, but no problem if you ignore them.

NickLarsenNZ
NickLarsenNZ previously approved these changes May 9, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing comment from previous review

Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi merged commit 55d2f9f into main May 9, 2025
2 checks passed
@Techassi Techassi deleted the feat/failure-success-notifications branch May 9, 2025 11:16
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering May 9, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants