Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Move file format handling out of systemdunit.rs #244

Open
@siegfriedweber

Description

@siegfriedweber

The module provider.systemdmanager.systemdunit is complex and hard to test because the service unit logic and the underlying INI file format are merged together. For more popular file formats like XML, JSON, and YAML it is obvious to use a separate module or library. The same can be done for the INI file format.

Furthermore the mapping from Kubernetes to a systemd service could be factored out. This would yield the following modules:

  • service_generator which maps a PodSpec to a SystemdService.
  • systemd_service which provides the structure SystemdService and a function serialize which maps this structure to an IniFile and calls serialize on it.
  • ini_file with a structure IniFile and a function serialize.

The amount of code would be roughly the same but there would be smaller and better testable modules.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions