This repository was archived by the owner on Dec 21, 2021. It is now read-only.
This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Move file format handling out of systemdunit.rs #244
Open
Description
The module provider.systemdmanager.systemdunit
is complex and hard to test because the service unit logic and the underlying INI file format are merged together. For more popular file formats like XML, JSON, and YAML it is obvious to use a separate module or library. The same can be done for the INI file format.
Furthermore the mapping from Kubernetes to a systemd service could be factored out. This would yield the following modules:
service_generator
which maps aPodSpec
to aSystemdService
.systemd_service
which provides the structureSystemdService
and a functionserialize
which maps this structure to anIniFile
and callsserialize
on it.ini_file
with a structureIniFile
and a functionserialize
.
The amount of code would be roughly the same but there would be smaller and better testable modules.