Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Move file format handling out of systemdunit.rs #244

Open
siegfriedweber opened this issue Jul 27, 2021 · 0 comments
Open

Move file format handling out of systemdunit.rs #244

siegfriedweber opened this issue Jul 27, 2021 · 0 comments

Comments

@siegfriedweber
Copy link
Member

siegfriedweber commented Jul 27, 2021

The module provider.systemdmanager.systemdunit is complex and hard to test because the service unit logic and the underlying INI file format are merged together. For more popular file formats like XML, JSON, and YAML it is obvious to use a separate module or library. The same can be done for the INI file format.

Furthermore the mapping from Kubernetes to a systemd service could be factored out. This would yield the following modules:

  • service_generator which maps a PodSpec to a SystemdService.
  • systemd_service which provides the structure SystemdService and a function serialize which maps this structure to an IniFile and calls serialize on it.
  • ini_file with a structure IniFile and a function serialize.

The amount of code would be roughly the same but there would be smaller and better testable modules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants