Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(superset): Add patch that fixes saved queries export #539

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 30, 2024

Description

Patch is taken from apache/superset#26889.

Ideally I would like to wait with merge until the linked PR is merged

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

@sbernauer sbernauer self-assigned this Jan 31, 2024
NickLarsenNZ
NickLarsenNZ previously approved these changes Feb 2, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever

superset/Dockerfile Show resolved Hide resolved
@sbernauer sbernauer requested a review from lfrancke February 2, 2024 14:27
superset/Dockerfile Outdated Show resolved Hide resolved
lfrancke
lfrancke previously approved these changes Feb 2, 2024
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, looks good otherwise

Co-authored-by: Lars Francke <lars.francke@stackable.tech>
@sbernauer sbernauer added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit 85c2740 Feb 5, 2024
12 of 13 checks passed
@sbernauer sbernauer deleted the fix/superset-export branch February 5, 2024 09:56
@lfrancke
Copy link
Member

lfrancke commented Feb 5, 2024

Just for documentation purposes: Can you briefly say which version of Superset you expect this to be released in?

@sbernauer
Copy link
Member Author

I'm not entirely sure, but I think it will be in the next patch releases of 3.0.x and 3.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants