Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default user id and gid #916

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Change default user id and gid #916

wants to merge 1 commit into from

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Nov 5, 2024

Description

Part of stackabletech/issues#645

Important

This should only be merged after the 24.11 release so it'll only make it into 25.3

Change default user id and gid to the same ones we use in the operators themselves.
These are only the defaults that are used when a Pod does not specify its own securityContext.runAsUser or runAsGroup.

As of now all our operators do set these (and fsGroup) to 1000 and 0 respectively.
As the next step we want to remove that hardcoding so the default would then fall back to what we specify here.

Therefore I do believe that this PR should be a simple change with no downstream consequences.

Definition of Done Checklist

Tasks

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@stackable-bot
Copy link
Contributor

stackable-bot commented Nov 5, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Development: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants