Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 21, 2023

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit eee2beb
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/64bf74992d7ad70008acb1d3
😎 Deploy Preview https://deploy-preview-426--stackable-docs.netlify.app/home/nightly/concepts/overrides
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sbernauer
Copy link
Member Author

@dmasice would you consider this helpful information or is something missing?

@dmasice
Copy link

dmasice commented Jul 21, 2023

@sbernauer Looks good to me, but maybe reference it too from the "Configuration & Environment Overrides" in the operator docs?

@sbernauer sbernauer self-assigned this Jul 21, 2023
@maltesander maltesander self-requested a review July 21, 2023 13:40
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

@dmasice linking needs to be done in every operator individually, so we can mgere this change and add the linking afterards

@sbernauer sbernauer merged commit 829932f into main Jul 25, 2023
@sbernauer sbernauer deleted the empty-conf-override branch July 25, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants