Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Sep 24, 2025

Description

Release 0.8.0

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated

Acceptance

  • Proper release label has been added

@lfrancke
Copy link
Member

I don't actually think we need a new release for this. The fact that it does compile against 34.0.0 without any changes is proof that the old version will work. We'd only need to do something as soon as we actually need to change anything in code.

@sbernauer
Copy link
Member

@lfrancke we already changed things in #134. I'd say we either revert that or release it 😅

If you trust Java enough (druid, guava, guice and jackson version mismatch) we can change the process to compile against a different Druid version than runtime. But I don't know enough and was better safe than sorry.
So I asked @xeniape to please bump it (so if it was unneeded it's my fault).

Actually I just noticed we are not building it from source (https://github.com/stackabletech/docker-images/blob/d5a77aa2727801d9a1c44f75541266826cf7c945/druid/Dockerfile#L104). Ideally we should do that (as we do with most tools, e.g. https://github.com/stackabletech/docker-images/blob/d5a77aa2727801d9a1c44f75541266826cf7c945/nifi/Dockerfile#L154-L157). If we build from source the problem immediately surfaces, as the Maven profile selection would fail for an unsupported Druid version

@xeniape
Copy link
Member Author

xeniape commented Sep 25, 2025

Tried compiling the druid-33.0.0 profile against Druid 34.0.0, it compiles successfully. The dependency tree shows some "omitted for conflict" messages for dependencies in druid-server dependency (and others), for example (com.fasterxml.jackson.core:jackson-annotations:jar:2.18.4:provided - omitted for conflict with 2.12.7) . But don't know if that might cause any problems as @sbernauer mentioned.
Also another perspective, shouldn't we bump the versions for possible CVE fixes in there? (Didn't check if there are any, just throwing it in)

@lfrancke
Copy link
Member

We don't introduce any new dependencies with this project. All dependencies are listed as "provided" which means we'll just use what's already there.

That is why we don't need this release. We confirmed that everything still compiles and that's enough. This release also doesn't hurt but it's not needed.

@xeniape
Copy link
Member Author

xeniape commented Sep 25, 2025

Alright, does #134 need reverting then or just leave it in for the case if we really start building druid-opa-authorizer from source in Druid?

@xeniape
Copy link
Member Author

xeniape commented Sep 25, 2025

Discussed in the planning meeting that the PR #134 will stay but no new release needed for now. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants