Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(kuttl): Remove the -o pipefail bash option #619

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Sep 2, 2024

Kuttl hard codes sh -c, instead of allowing alternative shells to be used.
For now, we need to drop the -o pipefail option.

I think kudobuilder/kuttl#50 was incorrectly closed, as the issue author asked for "bash script".

Note

For Macos and NixOs users, sh appears to work like bash, so locally set -euo pipfail worked fine.

@NickLarsenNZ NickLarsenNZ self-assigned this Sep 2, 2024
Copy link
Contributor

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Assume you've tested

@NickLarsenNZ
Copy link
Member Author

I have raised kudobuilder/kuttl#557

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Sep 2, 2024

LGTM, Assume you've tested

I have run one of the overlay tests and it passes:

=== NAME  kuttl
    harness.go:408: run tests finished
    harness.go:516: cleaning up
    harness.go:573: removing temp folder: ""
--- PASS: kuttl (298.95s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/overrides_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-latest-3.4.0_openshift-false (298.94s)
PASS

--test-suite smoke-latest passes too: druid-operator-it-custom/16

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 0cf0b46 Sep 2, 2024
31 checks passed
@NickLarsenNZ NickLarsenNZ deleted the kuttl-remove-pipefail branch September 2, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants