Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions #620

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add descriptions #620

merged 2 commits into from
Sep 12, 2024

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Sep 11, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tinytinytiny thing. LGTM otherwise!

docs/modules/druid/pages/getting_started/first_steps.adoc Outdated Show resolved Hide resolved
Co-authored-by: Malte Sander <contact@maltesander.com>
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@fhennig fhennig added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit cacb557 Sep 12, 2024
31 checks passed
@fhennig fhennig deleted the docs-add-descriptions branch September 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants