chore: Version CRD and HbaseClusterConfig #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
approved these changes
Feb 5, 2025
| pub authentication: Option<AuthenticationConfig>, | ||
|
|
||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub authorization: Option<AuthorizationConfig>, |
There was a problem hiding this comment.
Is crd::security::AuthorizationConfig not supposed to be versioned?
Comment on lines
+1
to
+3
| //! Ensures that `Pod`s are configured and running for each [`HbaseCluster`][v1alpha1] | ||
| //! | ||
| //! [v1alpha1]: crate::crd::v1alpha1::HbaseCluster |
There was a problem hiding this comment.
suggestion: specify the version in the docs 9to make it more obvious if the parameters change version.
Suggested change
| //! Ensures that `Pod`s are configured and running for each [`HbaseCluster`][v1alpha1] | |
| //! | |
| //! [v1alpha1]: crate::crd::v1alpha1::HbaseCluster | |
| //! Ensures that `Pod`s are configured and running for each [`v1alpha1::HbaseCluster`] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#642
This PR adds versioning to the HBase CRD and cluster config. It doesn't introduce any new version or updates the CRD in any way. It currently emits the same
crd.yamlwhich is the correct expected behaviour.Tip
It is recommended to look at this PR on a commit-by-commit basis to better understand the individual steps taken. Also take a look at the macro documentation.