Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add support for config overrides #122

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Add support for config overrides #122

wants to merge 6 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Feb 15, 2022

Description

Fixes #110

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan requested a review from a team February 15, 2022 14:06
maltesander
maltesander approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@razvan
Copy link
Member Author

razvan commented Feb 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2022
@razvan
Add support for config overrides (#122)
b11ba37 
## Description

Fixes #110
@bors
Copy link
Contributor

bors bot commented Feb 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add support for config overrides [Merged by Bors] - Add support for config overrides Feb 15, 2022
@bors bors bot closed this Feb 15, 2022
@bors bors bot deleted the config-overrides branch February 15, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document supported config overrides
2 participants
@razvan @maltesander