Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix hadoop cli tool #148

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Fix hadoop cli tool #148

wants to merge 4 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Mar 23, 2022 •
edited by siegfriedweber
Loading

Description

  • renamed HADOOP_OPTS for jmx exporter to HADOOP_{NAMENODE, DATANODE, JOURNALNODE}_OPTS
  • updated to operator-rs 0.15.0

fixes #138

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team March 23, 2022 14:13
@maltesander maltesander marked this pull request as ready for review March 23, 2022 14:14
@siegfriedweber siegfriedweber requested review from siegfriedweber and removed request for a team March 28, 2022 09:47
siegfriedweber
siegfriedweber approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 28, 2022
@maltesander
Fix hadoop cli tool (#148)
d992977 
## Description

- renamed HADOOP_OPTS for jmx exporter to HADOOP_{NAMENODE, DATANODE, JOURNALNODE}_OPTS
- updated to operator-rs 0.15.0

fixes #138



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix hadoop cli tool [Merged by Bors] - Fix hadoop cli tool Mar 28, 2022
@bors bors bot closed this Mar 28, 2022
@bors bors bot deleted the fix_hadoop_cli_tool branch March 28, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The hdfs/hadoop CLI tool does not work properly within the pods
2 participants
@maltesander @siegfriedweber