Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Consolidate top level config #326

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Consolidate top level config #326

wants to merge 7 commits into from

Conversation

maltesander
Copy link
Member

Description

Part of #289

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. changelog/crd-change labels Mar 6, 2023
@maltesander maltesander requested a review from a team March 6, 2023 11:01
@maltesander maltesander self-assigned this Mar 6, 2023
This was referenced Mar 6, 2023
Closed
Closed
@fhennig fhennig self-requested a review March 6, 2023 12:46
@maltesander maltesander mentioned this pull request Mar 6, 2023
Closed
7 tasks
@maltesander
Copy link
Member Author

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/54/

@fhennig
Copy link
Contributor

fhennig commented Mar 6, 2023

Code looks good 👍

@maltesander maltesander mentioned this pull request Mar 6, 2023
Closed
7 tasks
fhennig
fhennig approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

molto bene!

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 6, 2023
@maltesander
Consolidate top level config (#326)
a19b8c8 
# Description

Part of #289



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Consolidate top level config [Merged by Bors] - Consolidate top level config Mar 6, 2023
@bors bors bot closed this Mar 6, 2023
@bors bors bot deleted the consolidate-top-level-config branch March 6, 2023 14:56
bors bot pushed a commit to stackabletech/hbase-operator that referenced this pull request Mar 6, 2023
@maltesander
Adapted tests & examples to new hdfs crd structure (#326)
aa01120 
# Description

part of stackabletech/hdfs-operator#289

blocked by stackabletech/hdfs-operator#326



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
bors bot pushed a commit to stackabletech/druid-operator that referenced this pull request Mar 7, 2023
@maltesander
Adapted tests & examples to new hdfs crd structure (#411)
8612930 
# Description

part of stackabletech/hdfs-operator#289

blocked by stackabletech/hdfs-operator#326



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
bors bot pushed a commit to stackabletech/trino-operator that referenced this pull request Mar 7, 2023
@maltesander
Adapted tests & examples to new hdfs crd structure (#394)
aaa5852 
# Description

part of stackabletech/hdfs-operator#289

blocked by stackabletech/hdfs-operator#326



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhennig fhennig fhennig approved these changes

Assignees

@maltesander maltesander

Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. status/blocker
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @fhennig