Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM config overrides #384

Merged
merged 4 commits into from
Aug 15, 2023
Merged

JVM config overrides #384

merged 4 commits into from
Aug 15, 2023

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 14, 2023

Description

CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/96/

Use JVM defaults explicitly.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@razvan razvan changed the title First working version. JVM config overrides Aug 14, 2023
@razvan razvan marked this pull request as ready for review August 14, 2023 13:26
@razvan razvan requested a review from a team August 14, 2023 13:26
@sbernauer
Copy link
Member

Note that the defaults with 30s are pretty high (e.g. for journalnodes and namenodes) but if it works that's great!

…overrides.adoc

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
Copy link
Member Author

razvan commented Aug 15, 2023

These are the JVM defaults that some customers use already. They are open for discussion of course.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point. Lets see how it goes!

@razvan razvan enabled auto-merge August 15, 2023 07:15
@razvan razvan added this pull request to the merge queue Aug 15, 2023
Merged via the queue into main with commit 8b278ba Aug 15, 2023
29 checks passed
@razvan razvan deleted the feat/jvm-sec-overrides branch August 15, 2023 07:23
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2023-11 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants