Skip to content

feat: Propagate externalTrafficPolicy from ListenerClass to Services #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 22, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented May 21, 2024

Description

New field was added in stackabletech/operator-rs#773 and stackabletech/operator-rs#789

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer requested a review from nightkr May 21, 2024 11:13
@sbernauer sbernauer changed the title feat: Propagate external_traffic_policy from ListenerClass to created Services feat: Propagate externalTrafficPolicy from ListenerClass to Services May 21, 2024
@sbernauer sbernauer self-assigned this May 22, 2024
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
@sbernauer sbernauer requested a review from nightkr May 22, 2024 09:05
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the op-rs release

sbernauer and others added 2 commits May 22, 2024 13:26
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
@sbernauer sbernauer requested a review from nightkr May 22, 2024 11:45
@sbernauer sbernauer added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit e8c6d7a May 22, 2024
32 checks passed
@sbernauer sbernauer deleted the feat/propagate-external-traffic-policy branch May 22, 2024 14:14
@lfrancke
Copy link
Member

Are there docs for this?
If not, can you please elaborate briefly what this is about?

@sbernauer
Copy link
Member Author

There are no docs (other than the CRD description), this PR literally takes the field external_traffic_policy from the ListenerClass and put's it on the created Services.
Reasoning is in stackabletech/operator-rs#773, but mainly

If i use the ListenerClass external-stable on IONOS k8s the LoadBalancer svc is not reachable. I did find out it's because we set externalTrafficPolicy: Local on the svc here.
This PR simply allows users to configure that field, which is than passed to the created Service. We leave the default as-is at Local, so we don't have any breaking change.

This change is needed for external-stable to work on IONOS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants