[Merged by Bors] - Allow mounting extra volumes into NiFi pods that processors may depend on #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
…i containern to allow providing files that processors may need. Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
nightkr
reviewed
Feb 23, 2023
Co-authored-by: Natalie <teo@nullable.se>
Added changelog entry. Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
|
As chatted with @soenkeliebau i would vote against merging this without prior discussion/ADR. |
sbernauer
reviewed
Feb 23, 2023
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
|
FYI, created stackabletech/issues#356 |
Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
pipern
reviewed
Mar 3, 2023
# Conflicts: # CHANGELOG.md # rust/crd/src/lib.rs
nightkr
reviewed
Mar 15, 2023
Co-authored-by: Natalie <teo@nullable.se>
Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
nightkr
previously approved these changes
Mar 16, 2023
nightkr
dismissed
their stale review
Discussion happening in stackabletech/druid-operator#415
|
I have updated this PR to reflect the discussion that happened in stackabletech/druid-operator#415 |
nightkr
approved these changes
Mar 16, 2023
|
sorry, spotted a small issue in the docs yaml. |
sbernauer
reviewed
Mar 16, 2023
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
approved these changes
Mar 16, 2023
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
…d on (#434) # Description Add option to specify extra Volumes that will be mounted into the NiFi containern to allow providing files that processors may need. This could be certificates, scheml files, configuration files for services to connect to .... Co-authored-by: Sönke Liebau <soenke.liebau@stackable.de>
bors bot
pushed a commit
to stackabletech/druid-operator
that referenced
this pull request
Mar 16, 2023
…stion tasks (#415) # Description Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs.. This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion. It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434 Co-authored-by: Sönke Liebau <soenke.liebau@stackable.de>
|
Build failed: |
bors bot
pushed a commit
to stackabletech/druid-operator
that referenced
this pull request
Mar 16, 2023
…stion tasks (#415) # Description Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs.. This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion. It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434 Co-authored-by: Sönke Liebau <soenke.liebau@stackable.de>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
…d on (#434) # Description Add option to specify extra Volumes that will be mounted into the NiFi containern to allow providing files that processors may need. This could be certificates, scheml files, configuration files for services to connect to .... Co-authored-by: Sönke Liebau <soenke.liebau@stackable.de>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option to specify extra Volumes that will be mounted into the NiFi containern to allow providing files that processors may need.
This could be certificates, scheml files, configuration files for services to connect to ....
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information