feat: Default stackableVersion to operator version #493
Conversation
CHANGELOG.md
Outdated
| @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Default stackableVersion to operator version ([#493]). | |||
There was a problem hiding this comment.
I'd say this needs a more prominent warning that this is a CRD change?
There was a problem hiding this comment.
Do you have any suggestion of what it could look like? Its non-breaking btw ;)
There was a problem hiding this comment.
Non-breaking but will require people to update their CRD
| - Default stackableVersion to operator version ([#493]). | |
| - CRD Change: Default stackableVersion to operator version ([#493]). | |
| While this is non breaking it changes the X field from Y to Z because it now FOO. | |
| You will need to deploy a new CRD |
There was a problem hiding this comment.
I have not checked if it's valid Markdown but something along those lines.
There was a problem hiding this comment.
WDYT of
- Default stackableVersion to operator version. It is recommended to remove
spec.image.stackableVersionfrom your custom resources ([feat: Default stackableVersion to operator version #493]).
There was a problem hiding this comment.
As you are on vacation, and @siegfriedweber needs this PR to continue his work I would go with my proposed entry. We can continue discussing it here, after we reach a conclusion we need to change it in all operators anyway (so one operator more does not make a big change)
There was a problem hiding this comment.
I need to resolve this for merging, reopening it afterwards
Description
Part of stackabletech/issues#404
Definition of Done Checklist
Author
Reviewer
Acceptance