Skip to content

chore!: Bump stackable-operator to 0.92.0 #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,30 @@ All notable changes to this project will be documented in this file.

### Added

- Adds new telemetry CLI arguments and environment variables ([#715]).
- Use `--file-log-max-files` (or `FILE_LOG_MAX_FILES`) to limit the number of log files kept.
- Use `--file-log-rotation-period` (or `FILE_LOG_ROTATION_PERIOD`) to configure the frequency of rotation.
- Use `--console-log-format` (or `CONSOLE_LOG_FORMAT`) to set the format to `plain` (default) or `json`.
- Log the startup event for bundle-builder and user-info-fetcher ([#703]).

### Changed

- BREAKING: Replace stackable-operator `initialize_logging` with stackable-telemetry `Tracing` ([#703], [#710]).
- BREAKING: Replace stackable-operator `initialize_logging` with stackable-telemetry `Tracing` ([#703], [#710], [#715]).
- operator-binary:
- The console log level was set by `OPA_OPERATOR_LOG`, and is now set by `CONSOLE_LOG`.
- The file log level was set by `OPA_OPERATOR_LOG`, and is now set by `FILE_LOG`.
- The console log level was set by `OPA_OPERATOR_LOG`, and is now set by `CONSOLE_LOG_LEVEL`.
- The file log level was set by `OPA_OPERATOR_LOG`, and is now set by `FILE_LOG_LEVEL`.
- The file log directory was set by `OPA_OPERATOR_LOG_DIRECTORY`, and is now set
by `ROLLING_LOGS_DIR` (or via `--rolling-logs <DIRECTORY>`).
by `FILE_LOG_DIRECTORY` (or via `--file-log-directory <DIRECTORY>`).
- bundle-builder:
- The console log level was set by `OPA_BUNDLE_BUILDER_LOG`, and is now set by `CONSOLE_LOG`.
- The file log level was set by `OPA_BUNDLE_BUILDER_LOG`, and is now set by `FILE_LOG`.
- The console log level was set by `OPA_BUNDLE_BUILDER_LOG`, and is now set by `CONSOLE_LOG_LEVEL`.
- The file log level was set by `OPA_BUNDLE_BUILDER_LOG`, and is now set by `FILE_LOG_LEVEL`.
- The file log directory was set by `OPA_BUNDLE_BUILDER_LOG_DIRECTORY`, and is now set
by `ROLLING_LOGS_DIR` (or via `--rolling-logs <DIRECTORY>`).
by `FILE_LOG_DIRECTORY` (or via `--file-log-directory <DIRECTORY>`).
- user-info-fetcher:
- The console log level was set by `OPA_OPERATOR_LOG`, and is now set by `CONSOLE_LOG`.
- The file log level was set by `OPA_OPERATOR_LOG`, and is now set by `FILE_LOG`.
- The console log level was set by `OPA_OPERATOR_LOG`, and is now set by `CONSOLE_LOG_LEVEL`.
- The file log level was set by `OPA_OPERATOR_LOG`, and is now set by `FILE_LOG_LEVEL`.
- The file log directory was set by `OPA_OPERATOR_LOG_DIRECTORY`, and is now set
by `ROLLING_LOGS_DIR` (or via `--rolling-logs <DIRECTORY>`).
by `FILE_LOG_DIRECTORY` (or via `--file-log-directory <DIRECTORY>`).
- Replace stackable-operator `print_startup_string` with `tracing::info!` with fields.
- BREAKING: Inject the vector aggregator address into the vector config using the env var `VECTOR_AGGREGATOR_ADDRESS` instead
of having the operator write it to the vector config ([#707]).
Expand All @@ -38,6 +42,7 @@ All notable changes to this project will be documented in this file.
[#707]: https://github.com/stackabletech/opa-operator/pull/707
[#709]: https://github.com/stackabletech/opa-operator/pull/709
[#710]: https://github.com/stackabletech/opa-operator/pull/710
[#715]: https://github.com/stackabletech/opa-operator/pull/715

## [25.3.0] - 2025-03-21

Expand Down
18 changes: 9 additions & 9 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 16 additions & 16 deletions Cargo.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repository = "https://github.com/stackabletech/opa-operator"

[workspace.dependencies]
product-config = { git = "https://github.com/stackabletech/product-config.git", tag = "0.7.0" }
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", features = ["telemetry", "versioned"], tag = "stackable-operator-0.91.1" }
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", features = ["telemetry", "versioned"], tag = "stackable-operator-0.92.0" }

anyhow = "1.0"
axum = "0.8"
Expand Down
14 changes: 7 additions & 7 deletions crate-hashes.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 6 additions & 10 deletions rust/operator-binary/src/controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,8 @@ fn build_server_rolegroup_daemonset(
.context(AddVolumeMountSnafu)?
.resources(merged_config.resources.to_owned().into());

let console_and_file_log_level = bundle_builder_log_level(merged_config);

cb_bundle_builder
.image_from_product_image(resolved_product_image) // inherit the pull policy and pull secrets, and then...
.image(opa_bundle_builder_image) // ...override the image
Expand All @@ -797,12 +799,10 @@ fn build_server_rolegroup_daemonset(
&bundle_builder_container_name,
)])
.add_env_var_from_field_path("WATCH_NAMESPACE", FieldPathEnvVar::Namespace)
.add_env_var("CONSOLE_LOG_LEVEL", console_and_file_log_level.to_string())
.add_env_var("FILE_LOG_LEVEL", console_and_file_log_level.to_string())
.add_env_var(
"CONSOLE_LOG",
bundle_builder_log_level(merged_config).to_string(),
)
.add_env_var(
"ROLLING_LOGS_DIR",
"FILE_LOG_DIRECTORY",
format!("{STACKABLE_LOG_DIR}/{bundle_builder_container_name}"),
)
.add_volume_mount(BUNDLES_VOLUME_NAME, BUNDLES_DIR)
Expand Down Expand Up @@ -1180,11 +1180,7 @@ fn build_opa_start_command(merged_config: &v1alpha1::OpaConfig, container_name:
// See https://stackoverflow.com/a/8048493

let logging_redirects = format!(
"&> >(CONSOLE_LEVEL={console} FILE_LEVEL={file} DECISION_LEVEL={decision} SERVER_LEVEL={server} OPA_ROLLING_LOG_FILE_SIZE_BYTES={OPA_ROLLING_LOG_FILE_SIZE_BYTES} OPA_ROLLING_LOG_FILES={OPA_ROLLING_LOG_FILES} STACKABLE_LOG_DIR={STACKABLE_LOG_DIR} CONTAINER_NAME={container_name} process-logs)",
file = file_log_level,
console = console_log_level,
decision = decision_log_level,
server = server_log_level
"&> >(CONSOLE_LEVEL={console_log_level} FILE_LEVEL={file_log_level} DECISION_LEVEL={decision_log_level} SERVER_LEVEL={server_log_level} OPA_ROLLING_LOG_FILE_SIZE_BYTES={OPA_ROLLING_LOG_FILE_SIZE_BYTES} OPA_ROLLING_LOG_FILES={OPA_ROLLING_LOG_FILES} STACKABLE_LOG_DIR={STACKABLE_LOG_DIR} CONTAINER_NAME={container_name} process-logs)"
);

// TODO: Think about adding --shutdown-wait-period, as suggested by https://github.com/open-policy-agent/opa/issues/2764
Expand Down