Skip to content

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Sep 16, 2025

Description

  • Improve the name types (e.g. proper distinction between label names and DNS subdomain names)
  • Add more name types (e.g. for all used Kubernetes resources)
  • Add code comments
  • Move the function build_role_group_service into the function build_headless_service
  • Move the function listener_ports into the function build_listener
  • Rewrite the code for the ListenerOperatorVolumeSourceBuilder
  • Add the created Listeners to the assertion of the smoke integration test

Part of #2

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Sep 16, 2025
@siegfriedweber siegfriedweber mentioned this pull request Sep 9, 2025
27 tasks
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siegfriedweber siegfriedweber added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 22198a2 Sep 22, 2025
17 of 18 checks passed
@siegfriedweber siegfriedweber deleted the name-types branch September 22, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants