Skip to content

Maybe get_recommended_labels should take a struct of named arguments #491

Closed
@nightkr

Description

@nightkr

The current list of string arguments is confusing to follow (especially if you don't use rust-analyzer with parameter inlays), and is confusing and error-prone to update in operators when new arguments are added (often in the middle of the list).

This PR adds another parameter to the list: https://github.com/stackabletech/operator-rs/pull/492/files#diff-f3a8a77aa3434fb4aef8eb9c3d011832fc27301972b9975aa303832c3ed33675 Clippy also complains about the many parameters.

This is the function in its current state: https://github.com/stackabletech/operator-rs/blob/main/src/labels.rs#L22

Acceptance criteria:

  • get_recommended_labels does not take so many arguments
  • with_recommended_labels also

Metadata

Metadata

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions