Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inject vector aggregator address into config as env #1000

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Apr 3, 2025

Description

Inject the vector aggregator address into the vector config file in vector containers using environment variables. This removes the need to resolve the vector aggregator discovery ConfigMap during reconciliation.

Tested the change locally with a logging integration test.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

labrenbe and others added 2 commits April 4, 2025 16:17
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Comment on lines +1424 to +1431
/// pod_builder.add_container(product_logging::framework::vector_container(
/// &resolved_product_image,
/// "config",
/// "log",
/// logging.containers.get(&Container::Vector),
/// resources,
/// vector_aggregator_config_map_name,
/// ).unwrap());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
/// pod_builder.add_container(product_logging::framework::vector_container(
/// &resolved_product_image,
/// "config",
/// "log",
/// logging.containers.get(&Container::Vector),
/// resources,
/// vector_aggregator_config_map_name,
/// ).unwrap());
/// pod_builder.add_container(product_logging::framework::vector_container(
/// &resolved_product_image,
/// "config",
/// "log",
/// logging.containers.get(&Container::Vector),
/// resources,
/// vector_aggregator_config_map_name,
/// ).unwrap());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants