Skip to content

Remove last_ update_time from ClusterCondition #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove last_ update_time from ClusterCondition #1054

wants to merge 6 commits into from

Conversation

maltesander
Copy link
Member

Description

fixes #1032

Zookeeper status:

status:
  conditions:
  - lastTransitionTime: "2025-06-12T10:58:13Z"
    message: All StatefulSet have the requested amount of ready replicas.
    status: "True"
    type: Available
  - message: The cluster is reconciled normally.
    status: "False"
    type: ReconciliationPaused
  - message: The cluster is running.
    status: "False"
    type: Stopped
  discoveryHash: "5807873964697571649"

@maltesander maltesander requested a review from a team June 12, 2025 11:05
@maltesander maltesander self-assigned this Jun 12, 2025
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Jun 12, 2025
Techassi
Techassi requested changes Jun 12, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we note down why this got removed in the PR description. We should also link to any other related issues/PRs.

crates/stackable-operator/CHANGELOG.md Outdated
@@ -8,6 +8,13 @@ All notable changes to this project will be documented in this file.

- Update `kube` to `1.1.0` ([#1049]).

### Removed

- Removed `last_update_time` from CRD ClusterCondition status ([#1054]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This should be marked as breaking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 and get a platform release note please :)

Copy link
Member Author

@maltesander maltesander Jun 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and dont feel its breaking. Applying the new CRD and installing the new operator version simply removes the last_updated_time from the CRD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be breaking for us, but some users might use this value. As such, a removal is a breaking change for them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the breaking hint 244bfbb

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 12, 2025
@maltesander maltesander requested a review from Techassi June 13, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer left review comments

@Techassi Techassi Awaiting requested review from Techassi

Requested changes must be addressed to merge this pull request.

Assignees

@maltesander maltesander

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClusterCondition::last_update_time is updated on no-ops, causing infinite reconciles (in the worst case)
3 participants
@maltesander @Techassi @sbernauer