Skip to content

Implement getter for PodIdentity fields. #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2021
Merged

Implement getter for PodIdentity fields. #215

merged 3 commits into from
Sep 20, 2021

Conversation

razvan
Copy link
Member

@razvan razvan commented Sep 20, 2021 •
edited
Loading

Description

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

@razvan razvan requested a review from a team September 20, 2021 08:33
maltesander
maltesander previously approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@razvan razvan requested a review from maltesander September 20, 2021 08:41
maltesander
maltesander previously approved these changes Sep 20, 2021
View reviewed changes
@razvan razvan requested a review from maltesander September 20, 2021 08:51
@razvan razvan merged commit e37b0d6 into main Sep 20, 2021
@razvan razvan deleted the getter-for-pod-identity-fields branch September 20, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razvan @maltesander