Better code for pod identity management [was: Schedule pods without ids]

CHANGELOG.md

@@ -4,6 +4,18 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Fixed
+- Bugfix: when scheduling a pod, `GroupAntiAffinityStrategy` should not skip nodes that are mapped by other pods from different role+group. ([#222])
+
+### Added
+- `identity.rs` a new module split out of `scheduler.rs` that bundles code for pod and node id management.
+- `identity::PodIdentityFactory` trait and one implementation called `identity::LabeledPodIdentityFactory`
+
+### Removed
+- BREAKING: `scheduler::PodToNodeMapping::from` ([#222])
+
+[#222]: https://github.com/stackabletech/operator-rs/pull/222
+
 ## [0.2.2] - 2021-09-21
 
 

src/error.rs

@@ -1,6 +1,6 @@
+use crate::name_utils;
 use crate::product_config_utils;
-use crate::{name_utils, scheduler};
-use std::collections::HashSet;
+use std::collections::{BTreeMap, HashSet};
 
 #[derive(Debug, thiserror::Error)]
 pub enum Error {
@@ -82,12 +82,6 @@ pub enum Error {
     )]
     RequiredFileMissing { search_path: Vec<String> },
 
-    #[error("Scheduler reported error: {source}")]
-    SchedulerError {
-        #[from]
-        source: scheduler::Error,
-    },
-
     #[error("ProductConfig Framework reported error: {source}")]
     ProductConfigError {
         #[from]
@@ -102,6 +96,43 @@ pub enum Error {
 
     #[error("Error converting CRD byte array to UTF-8")]
     FromUtf8Error(#[from] std::string::FromUtf8Error),
+    #[error(
+    "Not enough nodes [{number_of_nodes}] available to schedule pods [{number_of_pods}]. Unscheduled pods: {unscheduled_pods:?}."
+    )]
+    NotEnoughNodesAvailable {
+        number_of_nodes: usize,
+        number_of_pods: usize,
+        unscheduled_pods: Vec<String>,
+    },
+
+    #[error(
+        "PodIdentity could not be parsed: [{pod_id}]. This should not happen. Please open a ticket."
+    )]
+    PodIdentityNotParseable { pod_id: String },
+
+    #[error("Cannot build PodIdentity from Pod without labels. Missing labels: {0:?}")]
+    PodWithoutLabelsNotSupported(Vec<String>),
+
+    #[error("Cannot build NodeIdentity from node without name.")]
+    NodeWithoutNameNotSupported,
+
+    #[error("Cannot construct PodIdentity from empty id field.")]
+    PodIdentityFieldEmpty,
+
+    #[error(
+        "Pod identity field [{field}] with value [{value}] does not match the expected value [{expected}]"
+    )]
+    UnexpectedPodIdentityField {
+        field: String,
+        value: String,
+        expected: String,
+    },
+
+    #[error("Forbidden separator [{separator}] found in pod identity fields [{invalid_fields:?}]")]
+    PodIdentityFieldWithInvalidSeparator {
+        separator: String,
+        invalid_fields: BTreeMap<String, String>,
+    },
 }
 
 pub type OperatorResult<T> = std::result::Result<T, Error>;